Skip to content

ruby_{3_3,3_4}: backport patches for GCC 15 and LLVM 21#451386

Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom
emilazy:push-omuwpnlxlxvn
Oct 13, 2025
Merged

ruby_{3_3,3_4}: backport patches for GCC 15 and LLVM 21#451386
vcunat merged 2 commits intoNixOS:staging-nextfrom
emilazy:push-omuwpnlxlxvn

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Oct 12, 2025 •
edited
Loading

Depends on #451385; only the last commit is relevant. Will retarget to staging-next after that is merged.

Closes: #449970
Closes: #450512

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy mentioned this pull request Oct 12, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 6.topic: vim Advanced text editor 8.has: documentation This PR adds or changes documentation labels Oct 12, 2025
@emilazy
ruby_{3_3,3_4}: backport patches for GCC 15 and LLVM 21
cdb57da 
Ruby 3.5.0-preview1 is also affected, but it’s several months old
and the patches do not apply cleanly to it. Hopefully that won’t
be a big deal, since the fixes will be picked up on the next update.

Closes: NixOS#449970
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 12, 2025
@emilazy emilazy changed the base branch from master to staging-next October 12, 2025 22:12
@nixpkgs-ci nixpkgs-ci bot closed this Oct 12, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Oct 12, 2025
@nixpkgs-ci nixpkgs-ci bot removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor labels Oct 12, 2025
@nix-owners nix-owners bot requested a review from manveru October 12, 2025 22:18
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 12, 2025
@vcunat
Copy link
Member

vcunat commented Oct 13, 2025

Rebuild: linux 15596, darwin 9251

🤔 a little bigger than anticipated (~50k together) and by looking at the counts, most of that must be outside rubyPackages* (Hydra shows less than 9k of those summed over all 4 platforms).

Let me try to reduce -linux, as that doesn't seem urgent.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Oct 13, 2025
@vcunat vcunat merged commit be33506 into NixOS:staging-next Oct 13, 2025
28 of 32 checks passed
@vcunat
Copy link
Member

vcunat commented Oct 13, 2025

Merging early, so that we reduce the amount of (darwin) builds that get finished and thrown away.

vcunat added a commit that referenced this pull request Oct 13, 2025
@vcunat
Revert "ruby: avoid rebuilding default ruby on linux for now"
bb7964b 
This reverts commit f0166da.
/cc PR #451386
@henrirosten henrirosten mentioned this pull request Oct 13, 2025
Merged
@emilazy emilazy deleted the push-omuwpnlxlxvn branch October 13, 2025 16:19
This was referenced Oct 14, 2025
Merged
Merged
@sheeeng
Copy link
Contributor

sheeeng commented Oct 15, 2025

Pardon my ignorance. Read NixOS/rfcs#26 (comment), but I still cannot figure out when does this fix progress from staging-next to nixos-unstable or nixpkgs-unstable?

How can I trace this fix to be made available in nixos-unstable or nixpkgs-unstable? 🙇

@johnhamelink
Copy link
Contributor

johnhamelink commented Oct 15, 2025

@sheeeng there are a number of "PR tracker" websites and browser extensions available which do this for you such as this: https://nixpk.gs/pr-tracker.html?pr=451386

@sheeeng
Copy link
Contributor

sheeeng commented Oct 15, 2025

@sheeeng there are a number of "PR tracker" websites and browser extensions available which do this for you such as this: https://nixpk.gs/pr-tracker.html?pr=451386

Oh my goodness! That's just so handy! Thank you so much for the tip!

@vcunat
Copy link
Member

vcunat commented Oct 15, 2025

Yes. And I think this is the best staging workflow reference:
https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#staging

GustavoWidman added a commit to GustavoWidman/nix that referenced this pull request Oct 15, 2025
@GustavoWidman
chore(flake): update inputs (! broken builds !)
a6316ea 
- disables metasploit because of broken `nokogiri`
build on darwin, see NixOS/nixpkgs#449970 (issue)
and respective NixOS/nixpkgs#451386 PR that's currently
only on `staging-next`.
- PR tracker: https://nixpk.gs/pr-tracker.html?pr=451386
GustavoWidman added a commit to GustavoWidman/nix that referenced this pull request Oct 15, 2025
@GustavoWidman
chore(flake): update inputs (! broken builds !)
e028297 
- disables metasploit because of broken `nokogiri`
build on darwin, see NixOS/nixpkgs#449970 (issue)
and respective NixOS/nixpkgs#451386 PR that's currently
only on `staging-next`.
- PR tracker: https://nixpk.gs/pr-tracker.html?pr=451386
@sheeeng
Copy link
Contributor

sheeeng commented Oct 20, 2025

... https://nixpk.gs/pr-tracker.html?pr=451386

I got 504 Gateway Time-out now. Did anyone have the same experience?

@vcunat
Copy link
Member

vcunat commented Oct 20, 2025 •
edited
Loading

Yes, me too right now. I expect it's overloaded right now, but generally it should work.

@vcunat
Copy link
Member

vcunat commented Oct 20, 2025 •
edited
Loading

For the merge to master itself you could e.g. follow PR #449539 directly on GitHub.

@mhanberg
Copy link
Contributor

mhanberg commented Oct 20, 2025

... https://nixpk.gs/pr-tracker.html?pr=451386

I got 504 Gateway Time-out now. Did anyone have the same experience?

https://nixpkgs-tracker.ocfox.me/?pr=451386

This tracker is more performant in my experience.

@HirschBerge
Copy link

HirschBerge commented Oct 20, 2025

... https://nixpk.gs/pr-tracker.html?pr=451386

I got 504 Gateway Time-out now. Did anyone have the same experience?

https://nixpkgs-tracker.ocfox.me/?pr=451386

This tracker is more performant in my experience.

Yes. This one is much better. the nixpk.gs, as well as just being bad also is has a node that is on quite a few known bad-rep trackers, so would keep throwing me alerts when I tried using it.

@sheeeng sheeeng mentioned this pull request Oct 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees

No one assigned

Labels

6.topic: ruby A dynamic, open source programming language with a focus on simplicity and productivity. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: rubyPackages_3_3.nokogiri

6 participants

@emilazy @vcunat @sheeeng @johnhamelink @mhanberg @HirschBerge